-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_cli_config_gen): Addressed missed comments for patch-panel #4078
Refactor(eos_cli_config_gen): Addressed missed comments for patch-panel #4078
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4078
# Activate the virtual environment
source test-avd-pr-4078/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@address-4063-comments#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,address-4063-comments --force
# Optional: Install AVD examples
cd test-avd-pr-4078
ansible-playbook arista.avd.install_examples |
Quality Gate passedIssues Measures |
https://github.com/aristanetworks/avd/pull/4078/files#diff-04eafc9714c156e4b9d33497f8abe2ff613613dee60edb095bbea33afd8b7c76L23-R26
Not able to comment on that line :) |
thanks for this comment ! I think we will stick with the schema from the original PR except if more people disagree / want to see it change? @ClausHolbechArista |
Other than this, LGTM |
Change Summary
Fix comments that were added in patch-panel PR #4063
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Add max values and group together min and max delay in reco
How to test
molecule
Checklist
Repository Checklist