Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cv_deploy): Improve SWG API handling for Zscaler internet exit #4090

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 7, 2024

Change Summary

Improve SWG API handling

Related Issue(s)

Fixes #4085

Component(s) name

arista.avd.cv_deploy

Proposed changes

  • Ensure that location data has a later timestamp than the request.

How to test

  • Tested manually by Vinay.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Jun 7, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4090
# Activate the virtual environment
source test-avd-pr-4090/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/cv_deploy/improve-swg-api-handling#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/cv_deploy/improve-swg-api-handling --force
# Optional: Install AVD examples
cd test-avd-pr-4090
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Jun 7, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review June 12, 2024 08:23
@ClausHolbechArista ClausHolbechArista requested review from a team as code owners June 12, 2024 08:23
Copy link

sonarcloud bot commented Jun 12, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista changed the title Fix(cv_deploy): Improve SWG API handling Fix(cv_deploy): Improve SWG API handling for Zscaler internet exit Jun 12, 2024
@ClausHolbechArista ClausHolbechArista merged commit 13d59c9 into aristanetworks:devel Jun 13, 2024
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(cv_deploy) role: eos_designs issue related to eos_designs role
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change of site location is not resulting in finding different Zscaler end point
1 participant