Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Adding option for arp cache persistent and arp persistent refresh-delay #4109

Merged
merged 7 commits into from
Jun 14, 2024

Conversation

bjmeuer
Copy link
Contributor

@bjmeuer bjmeuer commented Jun 12, 2024

Change Summary

Adding option for arp cache persistent and arp persistent refresh-delay

Related Issue(s)

Fixes #4106

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Under the existing key "arp" two new options are added:

arp:
    type: dict
    keys:
      persistent:
        type: dict
        keys:
          enabled:
            type: bool
            required: true
            description: Restore the ARP cache after reboot
          refresh_delay:
            type: int
            description: Time to wait in seconds before refreshing the ARP cache after reboot (EOS default 600).
            default: 600
            min: 600
            max: 3600
            convert_types:
              - str

How to test

arp:
  persistent: 
    enabled: true
    refresh_delay: 700

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@bjmeuer bjmeuer requested review from a team as code owners June 12, 2024 12:02
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4109
# Activate the virtual environment
source test-avd-pr-4109/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/bjmeuer/avd.git@arp_cache_persistent#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/bjmeuer/avd.git#/ansible_collections/arista/avd/,arp_cache_persistent --force
# Optional: Install AVD examples
cd test-avd-pr-4109
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 12, 2024
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 13, 2024
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit 5b88366 into aristanetworks:devel Jun 14, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Support for arp cache persistent
3 participants