Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Move eos_designs_facts to PyAVD #4110

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Jun 13, 2024

Change Summary

Move eos_designs_facts to PyAVD

Proposed changes

  • Moving the code for the EosDesignsFacts class to PyAVD.
  • Handle try/expect imports from the various Ansible-AVD components importing this.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4110
# Activate the virtual environment
source test-avd-pr-4110/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4110
ansible-playbook arista.avd.install_examples

@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_designs): Move eos_designs_facts to pyavd Refactor(eos_designs): Move eos_designs_facts to PyAVD Jun 13, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd branch from f995f74 to 9b8e443 Compare June 13, 2024 07:08
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added state: conflict PR with conflict and removed state: conflict PR with conflict labels Jun 14, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd branch from 17af9b2 to c2273f7 Compare June 14, 2024 06:43
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jun 14, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review June 14, 2024 11:52
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner June 14, 2024 11:52
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner June 14, 2024 11:52
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
11 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - tested on internal lab inventory

@carlbuchmann carlbuchmann requested a review from gmuloc June 14, 2024 14:53
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 36224dc into aristanetworks:devel Jun 14, 2024
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Refactor(eos_designs) role: eos_validate_state type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants