-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): Move eos_designs_facts to PyAVD #4110
Refactor(eos_designs): Move eos_designs_facts to PyAVD #4110
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4110
# Activate the virtual environment
source test-avd-pr-4110/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-logic-for-eos_designs_facts-to-pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4110
ansible-playbook arista.avd.install_examples |
f995f74
to
9b8e443
Compare
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
17af9b2
to
c2273f7
Compare
…igns_facts-to-pyavd
…igns_facts-to-pyavd
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - tested on internal lab inventory
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Move eos_designs_facts to PyAVD
Proposed changes
EosDesignsFacts
class to PyAVD.How to test
Checklist
User Checklist
Repository Checklist