Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.hide_passwords to PyAVD #4112

Merged

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jun 13, 2024

Change Summary

Move jinja filter code for arista.avd.hide_passwords to PyAVD

Related Issue(s)

Fixes #4111

Component(s) name

Filter:

  • arista.avd.hide_passwords

Proposed changes

Moving the code and unit tests for arista.avd.list_compress filter to PyAVD

How to test

CI should catch things.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4112
# Activate the virtual environment
source test-avd-pr-4112/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@hide_passwords_to_pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,hide_passwords_to_pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4112
ansible-playbook arista.avd.install_examples

python-avd/pyavd/j2filters/hide_passwords.py Outdated Show resolved Hide resolved
python-avd/pyavd/j2filters/hide_passwords.py Outdated Show resolved Hide resolved
python-avd/pyavd/j2filters/hide_passwords.py Outdated Show resolved Hide resolved
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review June 14, 2024 07:21
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners June 14, 2024 07:21
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ClausHolbechArista ClausHolbechArista merged commit 94e9c92 into aristanetworks:devel Jun 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor(plugins): Move jinja filter code for arista.avd.hide_passwords to PyAVD
5 participants