-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Move jinja filter code for arista.avd.hide_passwords to PyAVD #4112
Merged
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
Shivani-gslab:hide_passwords_to_pyavd
Jun 14, 2024
Merged
Refactor(plugins): Move jinja filter code for arista.avd.hide_passwords to PyAVD #4112
ClausHolbechArista
merged 7 commits into
aristanetworks:devel
from
Shivani-gslab:hide_passwords_to_pyavd
Jun 14, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4112
# Activate the virtual environment
source test-avd-pr-4112/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@hide_passwords_to_pyavd#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,hide_passwords_to_pyavd --force
# Optional: Install AVD examples
cd test-avd-pr-4112
ansible-playbook arista.avd.install_examples |
Shivani-gslab
force-pushed
the
hide_passwords_to_pyavd
branch
from
June 14, 2024 06:23
2d8f754
to
a516dba
Compare
MaheshGSLAB
reviewed
Jun 14, 2024
Co-authored-by: Mahesh Kumar <[email protected]>
Co-authored-by: Mahesh Kumar <[email protected]>
for more information, see https://pre-commit.ci
Vibhu-gslab
approved these changes
Jun 14, 2024
ClausHolbechArista
approved these changes
Jun 14, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move jinja filter code for arista.avd.hide_passwords to PyAVD
Related Issue(s)
Fixes #4111
Component(s) name
Filter:
arista.avd.hide_passwords
Proposed changes
Moving the code and unit tests for arista.avd.list_compress filter to PyAVD
How to test
CI should catch things.
Checklist
Repository Checklist