Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja filter code for arista.avd.generate_esi to PyAVD #4114

Merged
merged 5 commits into from
Jun 14, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Move jinja filter code for arista.avd.generate_esi to PyAVD

Related Issue(s)

Fixes #4113

Component(s) name

arista.avd.generate_esi

Proposed changes

Moving the code and unit tests for arista.avd.generate_esi filter to PyAVD

How to test

CI should catch things.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Jun 13, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4114
# Activate the virtual environment
source test-avd-pr-4114/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@generate_esi#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,generate_esi --force
# Optional: Install AVD examples
cd test-avd-pr-4114
ansible-playbook arista.avd.install_examples

MaheshGSLAB
MaheshGSLAB previously approved these changes Jun 14, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added state: conflict PR with conflict and removed state: conflict PR with conflict labels Jun 14, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review June 14, 2024 08:28
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners June 14, 2024 08:28
python-avd/pyavd/j2filters/generate_esi.py Outdated Show resolved Hide resolved
python-avd/pyavd/j2filters/generate_esi.py Outdated Show resolved Hide resolved
python-avd/tests/pyavd/j2filters/test_esi_management.py Outdated Show resolved Hide resolved
python-avd/Makefile Outdated Show resolved Hide resolved
@Vibhu-gslab Vibhu-gslab marked this pull request as draft June 14, 2024 10:44
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 14, 2024
Copy link

sonarcloud bot commented Jun 14, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 3176868 into aristanetworks:devel Jun 14, 2024
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(plugins) type: Python filters
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor(plugins): Move jinja filter code for arista.avd.generate_esi to PyAVD
5 participants