Feat(eos_designs): Enforce unicity of region IDs and per-region site IDs for CV Pathfinder #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4121
# Activate the virtual environment
source test-avd-pr-4121/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@unique-id-regions-and-sites#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,unique-id-regions-and-sites --force
# Optional: Install AVD examples
cd test-avd-pr-4121
ansible-playbook arista.avd.install_examples |
...tions/arista/avd/roles/eos_designs/schemas/schema_fragments/cv_pathfinder_regions.schema.yml
Outdated
Show resolved
Hide resolved
ClausHolbechArista
approved these changes
Jun 17, 2024
ClausHolbechArista
added
the
one approval
ClausHolbechArista
approved these changes
Jun 17, 2024
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
state: conflict
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…IDs for CV Pathfinder
carlbuchmann
force-pushed
the
unique-id-regions-and-sites
branch
from
79b408e
to
7de4031
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
github-actions
bot
added
state: conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
This is captured in the description. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Leverage
unique_keysintroduced in #3725 as plannedComponent(s) name
arista.avd.eos_designsProposed changes
CF schema fragment changes
How to test
Tested locally by triggering conflicting scenario (
unique_keyswork as expected)Checklist
Repository Checklist