-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Support of BGP default-originate per VRF #3941 #4122
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4122
# Activate the virtual environment
source test-avd-pr-4122/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/mmaaloul/ansible-avd.git@fix_issue_3941#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/mmaaloul/ansible-avd.git#/ansible_collections/arista/avd/,fix_issue_3941 --force
# Optional: Install AVD examples
cd test-avd-pr-4122
ansible-playbook arista.avd.install_examples |
...e_collections/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/router-bgp-evpn.yml
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/router-bgp.md
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/schemas/schema_fragments/router_bgp.schema.yml
Outdated
Show resolved
Hide resolved
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
We have moved a lot of things around in the code base these last few days, so I will rebase this one for you. |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
Change Summary
Adding the support of default route originate per VRF for address families EVPN and VPN-IPV4/VPN-IPV6
Related Issue(s)
Fixes #3941
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Changes under schema fragment
router_bgp
:vrfs
items, adding a list of dict nameddefault_route_export
address_family_evpn/peer_groups
items, adding a dict nameddefault_route
. Same foraddress_family_vpn_ipv4
andaddress_family_vpn_ipv6
How to test
Tested locally for 1 address family (evpn) using the 4 different flavours (default, using
always
, usingroute-map
and usingrcf
)Checklist
Repository Checklist