Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Support of BGP default-originate per VRF #3941 #4122

Merged
merged 7 commits into from
Jun 21, 2024

Conversation

mmaaloul
Copy link
Contributor

Change Summary

Adding the support of default route originate per VRF for address families EVPN and VPN-IPV4/VPN-IPV6

Related Issue(s)

Fixes #3941

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Changes under schema fragment router_bgp:

  • Under vrfs items, adding a list of dict named default_route_export
  • Under address_family_evpn/peer_groups items, adding a dict named default_route. Same for address_family_vpn_ipv4 and address_family_vpn_ipv6

How to test

Tested locally for 1 address family (evpn) using the 4 different flavours (default, using always, using route-map and using rcf)

Checklist

Repository Checklist

  • [x ] My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@mmaaloul mmaaloul requested review from a team as code owners June 17, 2024 13:07
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4122
# Activate the virtual environment
source test-avd-pr-4122/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/mmaaloul/ansible-avd.git@fix_issue_3941#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/mmaaloul/ansible-avd.git#/ansible_collections/arista/avd/,fix_issue_3941 --force
# Optional: Install AVD examples
cd test-avd-pr-4122
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jun 17, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team June 18, 2024 12:27
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jun 18, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 19, 2024
@ClausHolbechArista
Copy link
Contributor

We have moved a lot of things around in the code base these last few days, so I will rebase this one for you.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 20, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the role: eos_designs issue related to eos_designs role label Jun 20, 2024
@ClausHolbechArista ClausHolbechArista dismissed their stale review June 20, 2024 11:58

missed some issues

@gmuloc gmuloc merged commit 0e7ab44 into aristanetworks:devel Jun 21, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Support of BGP default-originate per VRF
5 participants