Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja test code for arista.avd.contains to PyAVD #4131

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jun 19, 2024

Change Summary

cf title

Component(s) name

plugins
pyavd

Proposed changes

  • Move test contains
  • Add pytest
  • Refactor python_wrapper

How to test

Molecule pass

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners June 19, 2024 09:48
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4131
# Activate the virtual environment
source test-avd-pr-4131/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@move-test-default#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,move-test-default --force
# Optional: Install AVD examples
cd test-avd-pr-4131
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jun 19, 2024
@github-actions github-actions bot removed the type: documentation Improvements or additions to documentation label Jun 19, 2024
@gmuloc gmuloc added this to the v4.9.0 milestone Jun 19, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 19, 2024
@ClausHolbechArista ClausHolbechArista merged commit d6e3870 into aristanetworks:devel Jun 19, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(plugins)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants