Refactor(plugins): Move jinja filter code for arista.avd.is_in_filter to PyAVD #4133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
filter: is_in_filter
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4133
# Activate the virtual environment
source test-avd-pr-4133/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@is_in_filter#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,is_in_filter --force
# Optional: Install AVD examples
cd test-avd-pr-4133
ansible-playbook arista.avd.install_examples |
Vibhu-gslab
force-pushed
the
is_in_filter
branch
from
8f0c7ba
to
57cdb6d
Compare
ClausHolbechArista
approved these changes
Jun 19, 2024
Vibhu-gslab
force-pushed
the
is_in_filter
branch
from
57cdb6d
to
5a9b349
Compare
gmuloc
reviewed
Jun 19, 2024
| (HOSTNAME_VALID, None, True), # default filter | ||
| (HOSTNAME_VALID, HOSTNAME_FILTER_VALID, True), # valid hostname | ||
| (HOSTNAME_INVALID, HOSTNAME_FILTER_VALID, False), # invalid hostname | ||
| # TODO: Check if this is a valid testcase. Add a type check? |
There was a problem hiding this comment.
This should not be working like this for the last example. Can you please log an issue to revisit the behavior of this filter after migration as changing this now would be a breaking change probably (here we end up looping over every character in the string and checking if any character is in the hostname, which is not the spirit of the filter, or at least should not be given like this as an input)
There was a problem hiding this comment.
There is some historic behavior here, where the device-filters in the cvp-related roles accepted a string or a list.
gmuloc
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Move jinja filter code for arista.avd.is_in_filter to PyAVD
Related Issue(s)
Fixes #4132
Component(s) name
arista.avd.is_in_filterProposed changes
Moving the code and unit tests for arista.avd.is_in_filter filter to PyAVD
How to test
CI should catch things.
Checklist
Repository Checklist