Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(plugins): Move jinja test code for arista.avd.defined to PyAVD #4143

Merged
merged 16 commits into from
Jun 21, 2024

Conversation

Vibhu-gslab
Copy link
Contributor

Change Summary

Move jinja test code for arista.avd.defined to PyAVD

Component(s) name

plugins
pyavd

Proposed changes

  • Move test contains
  • Add pytest
  • Refactor python_wrapper

How to test

Molecule pass

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Vibhu-gslab Vibhu-gslab self-assigned this Jun 20, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4143
# Activate the virtual environment
source test-avd-pr-4143/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@defined#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,defined --force
# Optional: Install AVD examples
cd test-avd-pr-4143
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 20, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 20, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jun 21, 2024
@github-actions github-actions bot removed the state: conflict PR with conflict label Jun 21, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review June 21, 2024 06:50
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners June 21, 2024 06:50
@github-actions github-actions bot added the state: conflict PR with conflict label Jun 21, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

python-avd/pyavd/j2tests/defined.py Outdated Show resolved Hide resolved
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jun 21, 2024
@ClausHolbechArista ClausHolbechArista merged commit cc10206 into aristanetworks:devel Jun 21, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(plugins)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants