-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(plugins): Deprecate various unused Ansible plugins #4166
Refactor(plugins): Deprecate various unused Ansible plugins #4166
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4166
# Activate the virtual environment
source test-avd-pr-4166/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/deprecate-plugins#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/deprecate-plugins --force
# Optional: Install AVD examples
cd test-avd-pr-4166
ansible-playbook arista.avd.install_examples |
python-avd/pyavd/_eos_designs/structured_config/underlay/port_channel_interfaces.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should add a note in the semantic versioning table, this will also remind us to remove it from there! https://github.com/aristanetworks/avd/blob/devel/ansible_collections/arista/avd/docs/semantic-versioning.md
If you agree I can do this and commit to your PR!
I considered this, but I do not want to have yet another place to track such things. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Deprecate various unused Ansible plugins
Proposed changes
The following Ansible plugins are no longer being used by AVD and have been deprecated for removal in AVD 5.0.0. See the plugin docs for possible replacements.
Filters:
arista.avd.generate_esi
arista.avd.generate_lacp_id
arista.avd.generate_route_target
Action plugins / Modules:
arista.avd.batch_template
arista.avd.validate_and_template
arista.avd.yaml_templates_to_facts
How to test
Hopefully no changes. The plugins are not being removed. Just deprecated.
Checklist
User Checklist
Repository Checklist