Refactor(eos_validate_state): Add warning for ansible test mode #4173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4173
# Activate the virtual environment
source test-avd-pr-4173/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@deprecate-legacy-validate-state#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,deprecate-legacy-validate-state --force
# Optional: Install AVD examples
cd test-avd-pr-4173
ansible-playbook arista.avd.install_examples |
ansible_collections/arista/avd/roles/eos_validate_state/README.md
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
type: documentation
ansible_collections/arista/avd/roles/eos_validate_state/tasks/ansible_tests.yml
Outdated
Show resolved
Hide resolved
github-actions
bot
added
the
state: CI Updated
ansible_collections/arista/avd/plugins/modules/_emit_warning.py
Outdated
Show resolved
Hide resolved
gmuloc
commented
Jul 3, 2024
ansible_collections/arista/avd/docs/plugins/Modules_and_action_plugins/_emit_warning.md
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
carlbuchmann
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Indicate that only
use_anta: truebehavior will be kept in 5.0.0Component(s) name
arista.avd.eos_validate_stateProposed changes
After too long searching, added a temporary action plugin to emit a warning. We will remove it when we remove the ansible-test before 5.0.0. This plugin is meant to be used only for this warning
How to test
In the molecule scenario for validate_state, set
use_antatofalseand run. The scenario will fail because it is not meant for this mode, but you will see the emitted warningChecklist
Repository Checklist