Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Deprecate Python3.9 support #4177

Merged
merged 4 commits into from
Jul 5, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 3, 2024

Change Summary

Prepare removal of 3.9 support in 5.0.0

Component(s) name

requirements
plugins

Proposed changes

Add warning when running verify requirements

How to test

Run with python 3.9 and watch

Screenshot 2024-07-03 at 15 32 46

Checklist

User Checklist

  • Add to release notes in deprecation

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 3, 2024 09:36
Copy link

github-actions bot commented Jul 3, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4177
# Activate the virtual environment
source test-avd-pr-4177/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@deprecate-python-3-9#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,deprecate-python-3-9 --force
# Optional: Install AVD examples
cd test-avd-pr-4177
ansible-playbook arista.avd.install_examples

@gmuloc gmuloc changed the title Chore: Deprecate Python3.9 support Refactor: Deprecate Python3.9 support Jul 3, 2024
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Jul 3, 2024
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jul 4, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 70ae53b into aristanetworks:devel Jul 5, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants