Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): Add option for ip igmp snooping fast-leave #4180

Merged
merged 9 commits into from
Jul 12, 2024
Merged

Feat(eos_designs): Add option for ip igmp snooping fast-leave #4180

merged 9 commits into from
Jul 12, 2024

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Jul 4, 2024 •
edited
Loading

Change Summary

Add option for ip igmp snooping fast-leave

Related Issue(s)

Fixes #3942

Component(s) name

arista.avd.eos_designs

Proposed changes

Adding fast_leave key to evnpn_l2_multicast and inner igmp_snooping_querier in tenants (network_services).
Inserting fast_leave config only if evpn_l2_multicast.enabled or inner igmp_snooping_querier.enabled is true and fast_leave is true.

How to test

Added tests in eos_designs_unit_tests molecule scenario in this PR. Test with EOS CLI.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 4, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4180
# Activate the virtual environment
source test-avd-pr-4180/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@fast_leave#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,fast_leave --force
# Optional: Install AVD examples
cd test-avd-pr-4180
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Jul 4, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review July 5, 2024 06:34
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners July 5, 2024 06:34
@Shivani-gslab Shivani-gslab marked this pull request as draft July 5, 2024 12:05
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 5, 2024 12:30
@laxmikantchintakindi
Copy link
Contributor

LGTM!

@laxmikantchintakindi laxmikantchintakindi marked this pull request as draft July 8, 2024 05:50
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 9, 2024 09:05
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jul 9, 2024
gmuloc
gmuloc requested changes Jul 9, 2024
View reviewed changes
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_svi_settings.schema.yml Outdated Show resolved Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml Outdated Show resolved Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml Outdated Show resolved Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml Show resolved Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml Show resolved Hide resolved
python-avd/pyavd/_eos_designs/structured_config/network_services/ip_igmp_snooping.py Show resolved Hide resolved
@Shivani-gslab Shivani-gslab marked this pull request as draft July 10, 2024 05:22
@Shivani-gslab Shivani-gslab marked this pull request as ready for review July 10, 2024 12:00
gmuloc
gmuloc reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some description schema changed I overlooked in my previous review - last changes and we can merge as far as I am concerned

python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_network_services.schema.yml Outdated Show resolved Hide resolved
python-avd/pyavd/_eos_designs/schema/schema_fragments/defs_svi_settings.schema.yml Outdated Show resolved Hide resolved
...ons/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/EVPN_MULTICAST_TESTS.yml Show resolved Hide resolved
@gmuloc gmuloc merged commit d8dcef0 into aristanetworks:devel Jul 12, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmuloc gmuloc gmuloc approved these changes

@Vibhu-gslab Vibhu-gslab Vibhu-gslab approved these changes

@laxmikantchintakindi laxmikantchintakindi laxmikantchintakindi approved these changes

Assignees

@Shivani-gslab Shivani-gslab

Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): add option for ip igmp snooping fast-leave
4 participants
@Shivani-gslab @laxmikantchintakindi @gmuloc @Vibhu-gslab