Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add support for tunnel-interface underlay vrf #4211

Merged
merged 4 commits into from
Jul 17, 2024

Conversation

nathanmusser
Copy link
Contributor

Change Summary

Add support for setting underlay vrf for a tunnel-interface

Related Issue(s)

Fixes #4165

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added underlay_vrf as a key to the tunnel-interfaces model. Setting this value will generate the following CLI config:

interface <tunnel_name>
   tunnel underlay vrf <vrf_name>

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4211
# Activate the virtual environment
source test-avd-pr-4211/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/nathanmusser/avd.git@tunnel-underlay-vrf#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/nathanmusser/avd.git#/ansible_collections/arista/avd/,tunnel-underlay-vrf --force
# Optional: Install AVD examples
cd test-avd-pr-4211
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jul 12, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for adding this

pf1(config-if-Tu42)#show cli command | grep 'tunnel underlay'
[no|default] tunnel underlay ( VRF_VRF_KW ( VRF_VRF_DYNAMIC ) )
pf1(config-if-Tu42)#tunnel underlay vrf ?
  WORD  VRF name

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Jul 15, 2024
@gmuloc gmuloc requested review from a team July 15, 2024 20:02
@gmuloc gmuloc merged commit dd0fac2 into aristanetworks:devel Jul 17, 2024
43 checks passed
@nathanmusser nathanmusser deleted the tunnel-underlay-vrf branch August 27, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add tunnel underlay vrf as key for the tunnel_interfaces in eos_cli_config_gen model
3 participants