-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Add ptp profiles for ITU-T G8275 support #4230
Feat(eos_cli_config_gen): Add ptp profiles for ITU-T G8275 support #4230
Conversation
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4230
# Activate the virtual environment
source test-avd-pr-4230/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/colinmacgiolla/ansible-avd.git@add_ptp_profiles#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/colinmacgiolla/ansible-avd.git#/ansible_collections/arista/avd/,add_ptp_profiles --force
# Optional: Install AVD examples
cd test-avd-pr-4230
ansible-playbook arista.avd.install_examples |
for more information, see https://pre-commit.ci
…ansible-avd into add_ptp_profiles
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor data model request but other than that looks good to me.
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/ethernet_interfaces.schema.yml
Outdated
Show resolved
Hide resolved
python-avd/pyavd/_eos_cli_config_gen/j2templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
@MaheshGSLAB - I'm not understanding why the negative test is failing on something that has nothing to do with my changes? |
Fixed now. Something sneaked in from another PR. |
Quality Gate passedIssues Measures |
Change Summary
Add support for settting the ITU-T G.8275.1 and .2 support, as well as allowing the handling of PTP frames on interfaces. See here for details on the feature.
Related Issue(s)
Fixes #
Component(s) name
arista.avd.pyavd.eos_cli_config_gen
Proposed changes
On the PTP level, we are just adding the
profile
key, which can be set tog8275_1
org8275_2
profiles.On the interface level we need to indicate if we should recognise either the
forwardable
ornon-forwardable
PTP frames.I've set the the following model on the port-channel and ethernet interface level:
How to test
Updated molecule tests to reflect device config
Checklist
User Checklist
Repository Checklist