Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_designs): Remove lookup plugin reference for Zscaler IE #4234

Merged
merged 4 commits into from
Jul 23, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 22, 2024

Change Summary

Doc has not been updated properly for Zcsaler IE Policy - the data is not retrieved using a lookup plugin anymore but fetched during eos_designs run from CVaaS

Related Issue(s)

Reported by systest

Component(s) name

arista.avd.eos_designs

Proposed changes

Remove legacy doc

How to test

No test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4234
# Activate the virtual environment
source test-avd-pr-4234/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@doc-fix-ie-doc#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,doc-fix-ie-doc --force
# Optional: Install AVD examples
cd test-avd-pr-4234
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Jul 22, 2024

@ClausHolbechArista ClausHolbechArista requested a review from a team July 22, 2024 15:05
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 22, 2024
@ClausHolbechArista ClausHolbechArista merged commit 1e06385 into aristanetworks:devel Jul 23, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD AutoVPN/WAN one approval This PR has one approval and is only missing one more. rn: Doc(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants