Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_designs): Update documentation to customize WAN flow tracking. #4253

Merged
merged 2 commits into from
Jul 25, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 24, 2024

Change Summary

The documentation is a bit outdated (though correct) as it is not mentioning the recently introduced keys

Component(s) name

arista.avd.eos_designs

Proposed changes

  • Add reference to the fabric_flow_tracking and flow_tracking_settings keys
  • Add an example on how to configure flow-tracking on a per WAN interface basis
  • Fix a schema description not mentioning the network-services l3_interfaces

How to test

only doc

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 24, 2024 08:31
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4253
# Activate the virtual environment
source test-avd-pr-4253/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@fix-doc-flow-tracking#subdirectory=python-avd" --force
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,fix-doc-flow-tracking --force
# Optional: Install AVD examples
cd test-avd-pr-4253
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Jul 24, 2024

@ClausHolbechArista ClausHolbechArista requested a review from a team July 24, 2024 09:12
@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Jul 24, 2024
@gmuloc gmuloc merged commit 7da9898 into aristanetworks:devel Jul 25, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Doc(eos_designs) role: eos_designs issue related to eos_designs role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants