Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_designs): Add warning about WAN BGP peer groups password #4265

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jul 26, 2024

Change Summary

Document some known issue for BGP peer group passwords

Component(s) name

arista.avd.eos_designs

Proposed changes

text about WAN BGP peer group passwords

How to test

no test

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners July 26, 2024 07:40
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4265
# Activate the virtual environment
source test-avd-pr-4265/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@doc-wan-rr-overlay-peer-grouppassword#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,doc-wan-rr-overlay-peer-grouppassword --force
# Optional: Install AVD examples
cd test-avd-pr-4265
ansible-playbook arista.avd.install_examples

@gmuloc gmuloc added this to the v4.10.0 milestone Jul 26, 2024
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please bring the schema descriptions in sync with the updated how-to warning.

Copy link

sonarcloud bot commented Jul 26, 2024

@ClausHolbechArista ClausHolbechArista merged commit 48445a4 into aristanetworks:devel Jul 26, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants