-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Remove deprecated key cvcompression from daemon_terminattr data model #4288
Merged
gmuloc
merged 3 commits into
aristanetworks:devel
from
Vibhu-gslab:dep_daemon_terminattr
Jul 30, 2024
Merged
Cut(eos_cli_config_gen): Remove deprecated key cvcompression from daemon_terminattr data model #4288
gmuloc
merged 3 commits into
aristanetworks:devel
from
Vibhu-gslab:dep_daemon_terminattr
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4288
# Activate the virtual environment
source test-avd-pr-4288/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@dep_daemon_terminattr#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,dep_daemon_terminattr --force
# Optional: Install AVD examples
cd test-avd-pr-4288
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
labels
Jul 30, 2024
MaheshGSLAB
reviewed
Jul 30, 2024
ansible_collections/arista/avd/roles/eos_cli_config_gen/docs/tables/daemon-terminattr.md
Show resolved
Hide resolved
…from daemon_terminattr data model
Vibhu-gslab
force-pushed
the
dep_daemon_terminattr
branch
from
July 30, 2024 10:30
3a717ed
to
82e8395
Compare
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
Jul 30, 2024
Vibhu-gslab
requested review from
MaheshGSLAB,
Shivani-gslab and
laxmikantchintakindi
July 30, 2024 10:32
ClausHolbechArista
changed the title
Refactor(eos_cli_config_gen): Removing deprecated keys cvcompression from daemon_terminattr data model
Cut(eos_cli_config_gen): Remove deprecated keys cvcompression from daemon_terminattr data model
Jul 30, 2024
ClausHolbechArista
changed the title
Cut(eos_cli_config_gen): Remove deprecated keys cvcompression from daemon_terminattr data model
Cut(eos_cli_config_gen): Remove deprecated key cvcompression from daemon_terminattr data model
Jul 30, 2024
MaheshGSLAB
approved these changes
Jul 30, 2024
Quality Gate passedIssues Measures |
gmuloc
approved these changes
Jul 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
rn: Cut(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Removing deprecated keys cvcompression from daemon_terminattr data model
Related Issue(s)
Fixes #
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Removing deprecated keys cvcompression from daemon_terminattr data model
Checklist
Repository Checklist