Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Remove deprecated keys from router_bgp data model #4311

Merged

Conversation

laxmikantchintakindi
Copy link
Contributor

@laxmikantchintakindi laxmikantchintakindi commented Aug 2, 2024

Change Summary

Remove deprecated keys from router_bgp data model.

Related Issue(s)

Fixes #3361

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Remove deprecated keys from router_bgp data model.

router_bgp.peer_groups[].peer_filter
router_bgp.peer_groups[].bgp_listen_range_prefix
router_bgp.address_family_ipv4.peer_groups[].next_hop.address_family_ipv6_originate
router_bgp.vrfs[].neighbors[].prefix_list_in | router_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_in
router_bgp.vrfs[].neighbors[].prefix_list_in | router_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_out
router_bgp.vrfs[].address_families

How to test

NA

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

github-actions bot commented Aug 2, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4311
# Activate the virtual environment
source test-avd-pr-4311/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@router_bgp_deprecated#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,router_bgp_deprecated --force
# Optional: Install AVD examples
cd test-avd-pr-4311
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Aug 2, 2024
@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Aug 2, 2024
@laxmikantchintakindi laxmikantchintakindi changed the title Cut(eos_cli_config_gen): Remove deprecated vars from router_bgp data model Cut(eos_cli_config_gen): Remove deprecated keys from router_bgp data model Aug 2, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review August 2, 2024 12:06
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners August 2, 2024 12:06
@ClausHolbechArista ClausHolbechArista added this to the v5.0.0-dev1 milestone Aug 2, 2024
@MaheshGSLAB MaheshGSLAB requested a review from a team August 2, 2024 13:13
@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 2, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 2, 2024

@gmuloc gmuloc merged commit 5e100db into aristanetworks:devel Aug 2, 2024
43 checks passed
@laxmikantchintakindi laxmikantchintakindi deleted the router_bgp_deprecated branch August 2, 2024 17:53
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor: AVD 5.0 Remove tmp_vrf_neighbor_prefix_list_in and tmp_vrf_neighbor_prefix_list_out
5 participants