-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cut(eos_cli_config_gen): Remove deprecated keys from router_bgp data model #4311
Merged
gmuloc
merged 6 commits into
aristanetworks:devel
from
laxmikantchintakindi:router_bgp_deprecated
Aug 2, 2024
Merged
Cut(eos_cli_config_gen): Remove deprecated keys from router_bgp data model #4311
gmuloc
merged 6 commits into
aristanetworks:devel
from
laxmikantchintakindi:router_bgp_deprecated
Aug 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4311
# Activate the virtual environment
source test-avd-pr-4311/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@router_bgp_deprecated#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,router_bgp_deprecated --force
# Optional: Install AVD examples
cd test-avd-pr-4311
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
role: eos_designs
issue related to eos_designs role
labels
Aug 2, 2024
github-actions
bot
added
the
type: documentation
Improvements or additions to documentation
label
Aug 2, 2024
laxmikantchintakindi
changed the title
Cut(eos_cli_config_gen): Remove deprecated vars from router_bgp data model
Cut(eos_cli_config_gen): Remove deprecated keys from router_bgp data model
Aug 2, 2024
MaheshGSLAB
reviewed
Aug 2, 2024
python-avd/pyavd/_eos_cli_config_gen/schema/schema_fragments/router_bgp.schema.yml
Show resolved
Hide resolved
MaheshGSLAB
approved these changes
Aug 2, 2024
gmuloc
approved these changes
Aug 2, 2024
gmuloc
added
the
one approval
This PR has one approval and is only missing one more.
label
Aug 2, 2024
carlbuchmann
approved these changes
Aug 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
…model (aristanetworks#4311) Co-authored-by: Carl Buchmann <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
one approval
This PR has one approval and is only missing one more.
rn: Cut(eos_cli_config_gen)
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
role: eos_designs
issue related to eos_designs role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Remove deprecated keys from router_bgp data model.
Related Issue(s)
Fixes #3361
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Remove deprecated keys from router_bgp data model.
router_bgp.peer_groups[].peer_filter
router_bgp.peer_groups[].bgp_listen_range_prefix
router_bgp.address_family_ipv4.peer_groups[].next_hop.address_family_ipv6_originate
router_bgp.vrfs[].neighbors[].prefix_list_in | router_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_in
router_bgp.vrfs[].neighbors[].prefix_list_in | router_bgp.vrfs[].address_family_ipv4.neighbors[].prefix_list_out
router_bgp.vrfs[].address_families
How to test
NA
Checklist
User Checklist
Repository Checklist