Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_designs): Remove deprecated key cvp_instance_ip #4317

Conversation

Shivani-gslab
Copy link
Contributor

@Shivani-gslab Shivani-gslab commented Aug 5, 2024

Change Summary

Remove deprecated key cvp_instace_ip

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Remove deprecated key cvp_instace_ip

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-gslab Shivani-gslab self-assigned this Aug 5, 2024
Copy link

github-actions bot commented Aug 5, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4317
# Activate the virtual environment
source test-avd-pr-4317/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Shivani-gslab/avd.git@cvp_instance_ip_derecated#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Shivani-gslab/avd.git#/ansible_collections/arista/avd/,cvp_instance_ip_derecated --force
# Optional: Install AVD examples
cd test-avd-pr-4317
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role type: documentation Improvements or additions to documentation labels Aug 5, 2024
@Vibhu-gslab Vibhu-gslab marked this pull request as ready for review August 5, 2024 11:23
@Vibhu-gslab Vibhu-gslab requested review from a team as code owners August 5, 2024 11:23
@ClausHolbechArista ClausHolbechArista changed the title Cut(eos_designs): Remove deprecated key cvp_instace_ip Cut(eos_designs): Remove deprecated key cvp_instance_ip Aug 5, 2024
Copy link

sonarcloud bot commented Aug 5, 2024

@ClausHolbechArista ClausHolbechArista merged commit 1097ab8 into aristanetworks:devel Aug 5, 2024
40 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants