Cut(eos_designs): Remove deprecated key short_esi

[Vibhu-gslab]

Change Summary

Remove deprecated key adapter_config.port_channel.short_esi

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Remove deprecated key adapter_config.port_channel.short_esi and code associated with it.

Checklist

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4319
# Activate the virtual environment
source test-avd-pr-4319/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/Vibhu-gslab/avd.git@def_short_esi#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/Vibhu-gslab/avd.git#/ansible_collections/arista/avd/,def_short_esi --force
# Optional: Install AVD examples
cd test-avd-pr-4319
ansible-playbook arista.avd.install_examples

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[Shivani-gslab]

LGTM!