-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_designs): Do not render vrf default under router ospf #4334
Merged
ClausHolbechArista
merged 2 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/eos_designs/do-not-render-vrf-default-for-router-ospf
Aug 9, 2024
Merged
Fix(eos_designs): Do not render vrf default under router ospf #4334
ClausHolbechArista
merged 2 commits into
aristanetworks:devel
from
ClausHolbechArista:fix/eos_designs/do-not-render-vrf-default-for-router-ospf
Aug 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Aug 8, 2024
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4334
# Activate the virtual environment
source test-avd-pr-4334/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/do-not-render-vrf-default-for-router-ospf#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/do-not-render-vrf-default-for-router-ospf --force
# Optional: Install AVD examples
cd test-avd-pr-4334
ansible-playbook arista.avd.install_examples |
4 tasks
MaheshGSLAB
approved these changes
Aug 9, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Vibhu-gslab
approved these changes
Aug 9, 2024
Quality Gate passedIssues Measures |
jrecchia1029
pushed a commit
to jrecchia1029/ansible-avd
that referenced
this pull request
Aug 14, 2024
ClausHolbechArista
deleted the
fix/eos_designs/do-not-render-vrf-default-for-router-ospf
branch
August 20, 2024 11:26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Do not render vrf default under router ospf
Related Issue(s)
Replaces #3976
Component(s) name
arista.avd.eos_designs
Proposed changes
When enabling OSPF under VRF default in network services we no longer render
vrf: default
in structured config. In turneos_cli_config_gen
will not renderrouter ospf <> vrf default
but justrouter ospf <>
How to test
Added molecule test coverage.
Checklist
User Checklist
Repository Checklist