Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Do not render vrf default under router ospf #4334

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Do not render vrf default under router ospf

Related Issue(s)

Replaces #3976

Component(s) name

arista.avd.eos_designs

Proposed changes

When enabling OSPF under VRF default in network services we no longer render vrf: default in structured config. In turn eos_cli_config_gen will not render router ospf <> vrf default but just router ospf <>

How to test

Added molecule test coverage.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested review from a team as code owners August 8, 2024 09:51
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4334
# Activate the virtual environment
source test-avd-pr-4334/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/eos_designs/do-not-render-vrf-default-for-router-ospf#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/eos_designs/do-not-render-vrf-default-for-router-ospf --force
# Optional: Install AVD examples
cd test-avd-pr-4334
ansible-playbook arista.avd.install_examples

Copy link
Contributor

@MaheshGSLAB MaheshGSLAB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MaheshGSLAB MaheshGSLAB requested a review from a team August 9, 2024 05:52
Copy link

sonarcloud bot commented Aug 9, 2024

@ClausHolbechArista ClausHolbechArista merged commit 904cd03 into aristanetworks:devel Aug 9, 2024
40 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
@ClausHolbechArista ClausHolbechArista deleted the fix/eos_designs/do-not-render-vrf-default-for-router-ospf branch August 20, 2024 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Fix(eos_designs) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants