Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cut(eos_cli_config_gen): Removing 'null' as valid value of esp integrity and encryption from ip-security module #4336

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

@MaheshGSLAB MaheshGSLAB commented Aug 8, 2024

Change Summary

Removing 'null' as valid values of esp integrity and encryption from ip-security module.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Removed the null as valid values of both esp integrity and encryption and added more valid values.

How to test

NA

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Aug 8, 2024
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4336
# Activate the virtual environment
source test-avd-pr-4336/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@ip-security#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,ip-security --force
# Optional: Install AVD examples
cd test-avd-pr-4336
ansible-playbook arista.avd.install_examples

@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review August 9, 2024 04:59
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners August 9, 2024 04:59
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can add test for the changes

@MaheshGSLAB MaheshGSLAB requested review from a team and Shivani-gslab August 9, 2024 07:26
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update title to say what you are actually removing.
Also update release notes and porting guide. The old "null" option has been replaced with "disabled".

@MaheshGSLAB MaheshGSLAB changed the title Cut(eos_cli_config_gen): Removed the TODO functionality from ip-security module Cut(eos_cli_config_gen): Removing 'null' as valid values of esp integrity and encryption from ip-security module Aug 9, 2024
@ClausHolbechArista ClausHolbechArista changed the title Cut(eos_cli_config_gen): Removing 'null' as valid values of esp integrity and encryption from ip-security module Cut(eos_cli_config_gen): Removing 'null' as valid value of esp integrity and encryption from ip-security module Aug 9, 2024
@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR labels Aug 9, 2024
Copy link
Contributor

@Vibhu-gslab Vibhu-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 9, 2024

@ClausHolbechArista ClausHolbechArista merged commit bee46a4 into aristanetworks:devel Aug 9, 2024
43 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn: Cut(eos_cli_config_gen) role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants