Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs): Provide the proper kwarg to Ansible Display.warning() in schema tools #4345

Conversation

carl-baillargeon
Copy link
Contributor

Change Summary

Ansible Display.warning() takes formatted kwarg and not text_wrap like his friend Display.error():
def warning(self, msg: str, formatted: bool = False) -> None:

Updated the caller in avdschematools accordingly. This is the only placed where Display.warning() is being used in the repo.

Related Issue(s)

Fixes #4344

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carl-baillargeon carl-baillargeon requested review from a team as code owners August 9, 2024 18:14
Copy link

github-actions bot commented Aug 9, 2024

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4345
# Activate the virtual environment
source test-avd-pr-4345/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/carl-baillargeon/avd.git@fix/schema_display_warning#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/carl-baillargeon/avd.git#/ansible_collections/arista/avd/,fix/schema_display_warning --force
# Optional: Install AVD examples
cd test-avd-pr-4345
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Aug 12, 2024

@ClausHolbechArista ClausHolbechArista merged commit db99705 into aristanetworks:devel Aug 12, 2024
39 of 40 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug(eos_designs): TypeError: Display.warning() got an unexpected keyword argument 'wrap_text'
2 participants