Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs, eos_validate_state): Updated the upper case letter Vxlan1 to vxlan1 for vxlan_interfaces structure config #4347

Merged
merged 2 commits into from
Aug 13, 2024

Conversation

MaheshGSLAB
Copy link
Contributor

Change Summary

Updated the upper case letter Vxlan1 to vxlan1 for vxlan_interfaces structure config.
Added the support of both Vxlan1 and vxlan1 in eos_validate_state role.

Related Issue(s)

Fixes #4339

Component(s) name

arista.avd.eos_designs, arista.avd.eos_validate_state

Proposed changes

Updated the upper case letter Vxlan1 to vxlan1 for vxlan_interfaces structure config.
Added the support of both Vxlan1 and vxlan1 in eos_validate_state role.>

How to test

Run molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@MaheshGSLAB MaheshGSLAB self-assigned this Aug 12, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4347
# Activate the virtual environment
source test-avd-pr-4347/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@issue-4339#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,issue-4339 --force
# Optional: Install AVD examples
cd test-avd-pr-4347
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added role: eos_validate_state state: CI Updated CI scenario have been updated in the PR labels Aug 12, 2024
@MaheshGSLAB MaheshGSLAB marked this pull request as ready for review August 13, 2024 04:52
@MaheshGSLAB MaheshGSLAB requested review from a team as code owners August 13, 2024 04:52
Copy link

sonarcloud bot commented Aug 13, 2024

Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit a582a3e into aristanetworks:devel Aug 13, 2024
40 checks passed
jrecchia1029 pushed a commit to jrecchia1029/ansible-avd that referenced this pull request Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate Upper case letter Vxlan1 to vxlan1 for eos_designs and update the same in eos_validate_role
4 participants