Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(cv_deploy): Fix Ansible Logging and increase API timeouts #4357

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Fix Ansible Logging and increase API timeouts to 600 seconds.

Component(s) name

arista.avd.cv_deploy

Proposed changes

  • Logging did not work correctly after we moved code to pyavd
  • API Timeouts of 10 seconds has proved to be too short, so increasing to 600 seconds as per dev recommendation.

How to test

Tested manually with molecule scenario cv_deploy

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista added the cherry-pick-for-4.10.x PR to be cherry-picked to releases/v4.10.x brach later label Aug 13, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4357
# Activate the virtual environment
source test-avd-pr-4357/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@fix/cv_deploy/logging-and-timeouts#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,fix/cv_deploy/logging-and-timeouts --force
# Optional: Install AVD examples
cd test-avd-pr-4357
ansible-playbook arista.avd.install_examples

Copy link
Contributor

@carl-baillargeon carl-baillargeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested locally.

@ClausHolbechArista ClausHolbechArista added one approval This PR has one approval and is only missing one more. type: bug Something isn't working labels Aug 14, 2024
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Aug 16, 2024

@carlbuchmann carlbuchmann merged commit 4d07a2d into aristanetworks:devel Aug 16, 2024
40 checks passed
@ClausHolbechArista ClausHolbechArista deleted the fix/cv_deploy/logging-and-timeouts branch August 20, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-for-4.10.x PR to be cherry-picked to releases/v4.10.x brach later one approval This PR has one approval and is only missing one more. rn: Fix(cv_deploy) type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants