Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Move documentation to Python #4364

Conversation

ClausHolbechArista
Copy link
Contributor

WIP!

Change Summary

Related Issue(s)

Fixes #

Component(s) name

arista.avd.<role-name>

Proposed changes

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4364
# Activate the virtual environment
source test-avd-pr-4364/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@refactor/eos_designs/move-documentation-to-python#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,refactor/eos_designs/move-documentation-to-python --force
# Optional: Install AVD examples
cd test-avd-pr-4364
ansible-playbook arista.avd.install_examples

Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/move-documentation-to-python branch from 664efbe to f72e9b0 Compare August 27, 2024 13:27
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 27, 2024
@ClausHolbechArista ClausHolbechArista force-pushed the refactor/eos_designs/move-documentation-to-python branch from f72e9b0 to 56822b7 Compare August 27, 2024 13:29
@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 27, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added the type: documentation Improvements or additions to documentation label Aug 28, 2024
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review August 29, 2024 07:04
Copy link

sonarcloud bot commented Aug 30, 2024

@gmuloc gmuloc added the one approval This PR has one approval and is only missing one more. label Aug 30, 2024
@ClausHolbechArista ClausHolbechArista merged commit 20da719 into aristanetworks:devel Aug 30, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_designs) role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants