Refactor(eos_designs)!: Change the default value of mlag_on_orphan_port_channel_downlink to false

[MaheshGSLAB]

Change Summary

Remove the default value true for mlag_on_orphan_port_channel_downlink, so it is now required to set mlag_on_orphan_port_channel_downlink: true to configure the MLAG ID on a downlink Port-Channel even if the downlink is only on one node in the MLAG pair.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Remove the default value(true) for mlag_on_orphan_port_channel_downlink.

How to test

Run molecule

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4371
# Activate the virtual environment
source test-avd-pr-4371/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/MaheshGSLAB/ansible-avd.git@mlag-orphan#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/MaheshGSLAB/ansible-avd.git#/ansible_collections/arista/avd/,mlag-orphan --force
# Optional: Install AVD examples
cd test-avd-pr-4371
ansible-playbook arista.avd.install_examples

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud