Refactor(eos_designs)!: Change the default value of isis_system_id_format to underlay_loopback

[laxmikantchintakindi]

Change Summary

Flip isis_system_id_format default to underlay_loopback.

Related Issue(s)

Fixes #

Component(s) name

arista.avd.eos_designs

Proposed changes

Flip isis_system_id_format default to underlay_loopback in AVD 5.0.

How to test

Checklist

User Checklist

• N/A

Repository Checklist

• My code has been rebased from devel before I start
• I have read the CONTRIBUTING document.
• My change requires a change to the documentation and documentation have been updated accordingly.
• I have updated molecule CI testing accordingly. (check the box if not applicable)

[github-actions]

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4373
# Activate the virtual environment
source test-avd-pr-4373/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/laxmikantchintakindi/avd.git@todo/flip_default_to_underlay_loopback#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/laxmikantchintakindi/avd.git#/ansible_collections/arista/avd/,todo/flip_default_to_underlay_loopback --force
# Optional: Install AVD examples
cd test-avd-pr-4373
ansible-playbook arista.avd.install_examples

[MaheshGSLAB]

updated the porting guide

[laxmikantchintakindi]

Added description of new changes in AVD to the porting-guide.

[ClausHolbechArista]

There must be test somewhere changing to the underlay_loopback. Flip this test to force it to node_id instead.

[laxmikantchintakindi]

There must be test somewhere changing to the underlay_loopback. Flip this test to force it to node_id instead.

We have yaml for both node-id and underlay-loopback.
'isis-system-id-format-using-underlay-looback.yml'
'isis-system-id-format-using-node-id.yml'

[github-actions]

This pull request has conflicts, please resolve those before we can evaluate the pull request.

[github-actions]

Conflicts have been resolved. A maintainer will review the pull request shortly.

[ClausHolbechArista]

Just some rewording. Other than that LGTM.

[sonarcloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud