Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs)!: Update the default platform settings for R3-series to have TCAM profile "vxlan-routing" #4387

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Update the default platform settings for R3-series to have TCAM profile "vxlan-routing"

Related Issue(s)

Replacing #3901

Component(s) name

arista.avd.eos_designs

Proposed changes

The default platform settings for R3-series now have the TCAM profile "vxlan-routing"

Starting AVD 5.0.0, the default platform settings for 7280R3, 7500R3 and 7800R3 platforms now contain tcam_profile: vxlan-routing
This change is based on a new Arista best practice for VXLAN deployments with the R3-series.
Not using this TCAM profile can lead to incorrect handling of VXLAN IPv6 NS packets.

!!! warning
Since applying a TCAM profile will cause reprogramming of the forwarding processor, it can lead to disturbances to the network services.

Please work with your Arista account team to decide if the new default is the right choice for your network, and how to apply it.

To retain the old configuration with no TCAM profile the default platform settings can be overridden with the new custom_platform_settings key:

+custom_platform_settings:
+  - platforms:
+      - 7280R3
+    reload_delay:
+      mlag: 900
+      non_mlag: 1020
+  - platforms:
+      - 7500R3
+      - 7800R3
+    management_interface: Management0
+    reload_delay:
+      mlag: 900
+      non_mlag: 1020

How to test

  • Existing molecule tests expose the change of defaults.
  • Updated one of them to test the suggested roll-back from porting guide.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4387
# Activate the virtual environment
source test-avd-pr-4387/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/ClausHolbechArista/avd.git@feat/eos_designs/platform-settings-r3-vxlan-routing#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/ClausHolbechArista/avd.git#/ansible_collections/arista/avd/,feat/eos_designs/platform-settings-r3-vxlan-routing --force
# Optional: Install AVD examples
cd test-avd-pr-4387
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added type: documentation Improvements or additions to documentation state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated role: eos_designs issue related to eos_designs role labels Aug 22, 2024
@ClausHolbechArista
Copy link
Contributor Author

@ClausHolbechArista ClausHolbechArista added this to the v5.0.0 milestone Aug 22, 2024
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 27, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Aug 27, 2024
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Aug 28, 2024
Copy link

sonarcloud bot commented Aug 28, 2024

Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thank you

@JulioPDX JulioPDX merged commit b0aff32 into aristanetworks:devel Aug 29, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Feat(eos_designs)! role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants