-
Notifications
You must be signed in to change notification settings - Fork 201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(eos_cli_config_gen): Use the correct VRF name for ip nat profile #4398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review docs on Read the Docs To test this pull request: # Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4398
# Activate the virtual environment
source test-avd-pr-4398/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4397#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4397 --force
# Optional: Install AVD examples
cd test-avd-pr-4398
ansible-playbook arista.avd.install_examples |
github-actions
bot
added
the
state: CI Updated
CI scenario have been updated in the PR
label
Aug 27, 2024
gmuloc
added
the
cherry-pick-for-4.10.x
PR to be cherry-picked to releases/v4.10.x brach later
label
Aug 27, 2024
Shivani-gslab
approved these changes
Aug 28, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
ClausHolbechArista
approved these changes
Aug 28, 2024
Quality Gate passedIssues Measures |
gmuloc
added a commit
to gmuloc/avd
that referenced
this pull request
Aug 28, 2024
ClausHolbechArista
added a commit
that referenced
this pull request
Aug 29, 2024
…4398) (#4405) Co-authored-by: Claus Holbech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
cherry-pick-for-4.10.x
PR to be cherry-picked to releases/v4.10.x brach later
rn: Fix(eos_cli_config_gen)
state: CI Updated
CI scenario have been updated in the PR
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
As described in the issue - wrong VRF name
Related Issue(s)
Fixes #4397
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
Use the proper variable in the template...
Checked that doc template is correct
How to test
molecule updated
Checklist
Repository Checklist