Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_cli_config_gen): Use the correct VRF name for ip nat profile #4398

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Aug 27, 2024

Change Summary

As described in the issue - wrong VRF name

Related Issue(s)

Fixes #4397

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Use the proper variable in the template...
Checked that doc template is correct

How to test

molecule updated

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners August 27, 2024 15:33
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4398
# Activate the virtual environment
source test-avd-pr-4398/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@issue/4397#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,issue/4397 --force
# Optional: Install AVD examples
cd test-avd-pr-4398
ansible-playbook arista.avd.install_examples

@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Aug 27, 2024
@gmuloc gmuloc added this to the v5.0.0 milestone Aug 27, 2024
@gmuloc gmuloc added the cherry-pick-for-4.10.x PR to be cherry-picked to releases/v4.10.x brach later label Aug 27, 2024
Copy link
Contributor

@Shivani-gslab Shivani-gslab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

sonarcloud bot commented Aug 28, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cherry-pick-for-4.10.x PR to be cherry-picked to releases/v4.10.x brach later rn: Fix(eos_cli_config_gen) state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ip_nat profiles setting the VRF name incorrectly
3 participants