Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Remove hack for ansible 2.12 for arp #4404

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Aug 28, 2024

Change Summary

Remove a hack that was there for 2.12.6 in ansible

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Clean the templates

How to test

molecule

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested review from a team as code owners August 28, 2024 10:27
@gmuloc gmuloc added this to the v5.0.0 milestone Aug 28, 2024
Copy link

Review docs on Read the Docs

To test this pull request:

# Create virtual environment for this testing below the current directory
python -m venv test-avd-pr-4404
# Activate the virtual environment
source test-avd-pr-4404/bin/activate
# Install all requirements including PyAVD
pip install "pyavd[ansible] @ git+https://github.com/gmuloc/avd.git@clean-arp#subdirectory=python-avd" --force
# Point Ansible collections path to the Python virtual environment
export ANSIBLE_COLLECTIONS_PATH=$VIRTUAL_ENV/ansible_collections
# Install Ansible collection
ansible-galaxy collection install git+https://github.com/gmuloc/avd.git#/ansible_collections/arista/avd/,clean-arp --force
# Optional: Install AVD examples
cd test-avd-pr-4404
ansible-playbook arista.avd.install_examples

Copy link

sonarcloud bot commented Aug 28, 2024

@ClausHolbechArista ClausHolbechArista added the one approval This PR has one approval and is only missing one more. label Aug 29, 2024
Copy link
Contributor

@JulioPDX JulioPDX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JulioPDX JulioPDX merged commit b0b6f4b into aristanetworks:devel Aug 29, 2024
43 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
one approval This PR has one approval and is only missing one more. rn: Refactor(eos_cli_config_gen)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants