-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a hook to get longitude and latitude #15
Add a hook to get longitude and latitude #15
Conversation
Yea assign me I fill send a PR |
@fernandoamz Please add the description, parameters and return value as per JSdoc guidelines. |
@aromalanil, I send the correction |
@fernandoamz Check out other suggestions also and remove the space between comment and the function. |
@fernandoamz I hope you can see the changes I have requested. If you can't I will mention it here.
return latLong
let userPosition = {
latitude = position.coords.latitude;
longitude = position.coords.longitude;
};
|
Oh, nice suggestions! I will fix it. thanks so much @aromalanil |
@fernandoamz I didn't notice this at first but did you really intend to use word Geo Localisation. The apt word would be Geo Location. And also a state is not needed for an error message. Also, It is not the best practice to return an error message, you can consider throwing an error. |
Hey!, @aromalanil, I followed up all your suggestions. Let me know if I need to do some other changes!. |
LGTM 👍🏻 |
@all-contributors please add @fernandoamz for code and doc |
I've put up a pull request to add @fernandoamz! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes made. approved for merging
Implements
Add a new hook to get the geolocalisation from the browser, the hook will get the permissions and it will return the values.