-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue running AsciidoctorJ out of process on Gradle 4.10 #269
Comments
GEM support: - Add compatibility test for gems support plugin. Reveal.js: - Reveal.js plugin & base plugin. - `revealjs` extension. - `revealjsPlugins` extension. - Plugin support is ignored if reveal.js backend < 1.2.0. - Compatibility test checks for content in generated files. JDK & Gradle support: - Upgradle build to 4.8.1. - Test with JDK8, JDK10, JDK11 on Travis. - Add Gradle 4.10.2 & Gradle 5.10-rc-1 to compatibility matrix. - Minimum Gradle version for compatibility testing on JDK11 is 4.8.1. - Use at least Jacoco 0.8.3 for JDK11. - Inject Guava classpath for Gradle 4.8. - Make publishing Gradle 5.0 compatible. - Work around Gradle 5.0 worker classpath leakage Miscellaneous: - Add upgrading note regarding extensions. - GitHub archives unpack in a repository-branch pattern. - Compatibility Asciidoctor Task will support legacy attributes. In order to ease migration `legacyAttributes=true` can be set on the compatibility conversion task. This will enable `projectdir` and `rootdir` attributes. it will also print a warning message to change the usage to the new attributes. - Under test if the Groovy versions are different, then run using JAVA_EXEC instead (asciidoctor#269).
Hi,
|
Try using 2.0-alpha.5 instead. We are only plannign to do a small maintenance releases on 1.5.x and currently there is no plan to fully support it on Gradle 5.x once the 2.x version of the plugin is released. |
Thank you for the answer. |
Asciidoctor 1.5.9.2 doesn't work on 4.10.3 either, even in-process. AD 1.5.9.2 DID work on Gradle 4.5.1, so something changed. |
Also had to downgrade to 1.5.3 to work with Gradle 5.2.1 |
@wimdeblauwe @shevek @ragnor Are any of you using |
Not me |
We are using build.gradle in groovy, no kts here. |
The issue is that AbstractAsciidoctorTask is including everything plus the kitchen sink on the classpath when it invokes an external JVM. Heaven only knows why half that stuff is on there, there's at least 3 groovy versions that I can see. It's including the entire runtime classpath for the project without even doing dependency resolution. So yes, it's SNAFU'd. |
I think I have tracked down the issue. I might do a maintenance release within the next two weeks. Time is limited atm. |
Finally got to do the fix for this after 2.1.0 was released and 2.2.0 work has bene prepped. The fix will be released in 1.5.12 and 1.6.1. Will get @aalmiray to release when he has the time. |
Is there a release of 1.5.12? asciidoctor just broke for us globally with no change on our side, so we're hunting for a bunch of outstanding fixes. :( |
Yes 1.5.12 & 1.6.1 was released some weeks ago. |
Thank you. Didn't see it on Central. See it now in Gradle plugins. |
Closing thisissue. Please raise a new one if you still see something similar. |
Running something like
will fail with an error
The text was updated successfully, but these errors were encountered: