Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docinfo is ignored in version 2.x of the plugin #368

Closed
ghost opened this issue May 3, 2019 · 6 comments
Closed

docinfo is ignored in version 2.x of the plugin #368

ghost opened this issue May 3, 2019 · 6 comments
Labels
2.x Issue related to the 2.x series bug
Milestone

Comments

@ghost
Copy link

ghost commented May 3, 2019

Trying to upgrade to version 2.1.0 of the asciidoctor-gradle-plugin.

I use a docinfo.html to include custom CSS and an import to the tocbot.js JavaScript library for an expandable table of contents.

My config:

plugins {
    id 'org.asciidoctor.jvm.convert' version '2.1.0'
}

repositories { jcenter() }

asciidoctor {
    sourceDir = file("src/docs/asciidoc/")
    ant.touch(file:"${sourceDir}/index.adoc")
    sources {
        include 'index.adoc'
    }
     resources {
        from(sourceDir) {
            include ('images/**', 'assets/js/**')
        }
    }
    outputDir "${project.buildDir}"
    attributes = [
            'doctype'      : 'article',
            'toc'          : 'left',
            'sectanchors'   : 'true',
            'toc-title'    :  'My Document',
            'source-highlighter': 'highlightjs',
            'imagesdir'    : './images',
            'docinfo1'     : ''
    ]
}

Result:

My docinfo.html is ignored, so that the custom CSS and JavaScript import are missing from the generated HTML.

@mojavelinux
Copy link
Member

mojavelinux commented May 3, 2019 via email

@ysb33r ysb33r added 2.x Issue related to the 2.x series bug labels May 3, 2019
@ysb33r
Copy link
Member

ysb33r commented May 3, 2019

@mojavelinux This will still use asciidoctorj 1.6, so I would expect docinfo1 to work.

@mojavelinux
Copy link
Member

I'm not suggesting docinfo1 wouldn't work (just that maybe there is something else going on). But the point is, no matter what version of AsciidoctorJ you're using, you shouldn't be using docinfo1. It's been deprecated for years.

@ysb33r
Copy link
Member

ysb33r commented May 4, 2019

@dcp65 problem reproduced, but no understanding yet why it is happening. Currently investigating this and hoping for a fix for 2.2.0.

@ysb33r
Copy link
Member

ysb33r commented May 4, 2019

Oh my, it is the old issue and it is baseDir again. Right, I am going to fix it it in this way:

ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue May 4, 2019
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue May 4, 2019
@ysb33r ysb33r added this to the 2.2.0 milestone May 4, 2019
This was referenced May 4, 2019
@ysb33r
Copy link
Member

ysb33r commented May 4, 2019

Fixed and scheduled for 2.2.0.

@ysb33r ysb33r closed this as completed May 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.x Issue related to the 2.x series bug
Projects
None yet
Development

No branches or pull requests

2 participants