Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If source filter pattern is specified, multi-language builds report NO-SOURCE. #401

Closed
ysb33r opened this issue Jun 16, 2019 · 1 comment
Closed

If source filter pattern is specified, multi-language builds report NO-SOURCE. #401

ysb33r opened this issue Jun 16, 2019 · 1 comment
Labels
3.x Issues related to the 3.x
Milestone
3.0.0

Comments

@ysb33r
Copy link
Member

ysb33r commented Jun 16, 2019 •
edited
Loading

This will always report NO-SOURCE.

asciidoctor {
    languages 'en'
    sources {
        include 'index.adoc'
   }
}
@ysb33r ysb33r added the 3.x Issues related to the 3.x label Jun 16, 2019
@ysb33r ysb33r added this to the 3.0.0 milestone Jun 16, 2019
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 16, 2019
@ysb33r
Source trees should report all language source sets (asciidoctor#401)
6195a89 
`getSourceFileTree` and `getSecondarySourceFileTree` now reports all of the source sets when
multiple languages are specified. This fix distinguishes between classic behaviour and
multi-language behaviour and will either return a single source set of a combination of source sets.

Credits to @ixchelruiz for helping to diagnose this problem at Hack.Commit.Push 2019.
@ysb33r ysb33r mentioned this issue Jun 16, 2019
Closed
24 tasks
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jun 16, 2019
@ysb33r
Source trees should report all language source sets (asciidoctor#401)
5c75bf3 
`getSourceFileTree` and `getSecondarySourceFileTree` now reports all of the source sets when
multiple languages are specified. This fix distinguishes between classic behaviour and
multi-language behaviour and will either return a single source set of a combination of source sets.

Credits to @ixchelruiz for helping to diagnose this problem at Hack.Commit.Push 2019.
ysb33r added a commit that referenced this issue Jun 16, 2019
@ysb33r
Merge pull request #402 from ysb33r/development-3.x
043f22b 
Source trees should report all language source sets (#401)
@ysb33r
Copy link
Member Author

ysb33r commented Jun 27, 2019

In 3.0.0-alpha.3

@ysb33r ysb33r closed this as completed Jun 27, 2019
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jan 18, 2020
@ysb33r
Source trees should report all language source sets (asciidoctor#401)
20c469e 
`getSourceFileTree` and `getSecondarySourceFileTree` now reports all of the source sets when
multiple languages are specified. This fix distinguishes between classic behaviour and
multi-language behaviour and will either return a single source set of a combination of source sets.

Credits to @ixchelruiz for helping to diagnose this problem at Hack.Commit.Push 2019.
ysb33r added a commit to ysb33r/asciidoctor-gradle-plugin that referenced this issue Jan 19, 2020
@ysb33r
Source trees should report all language source sets (asciidoctor#401)
dda2de2 
`getSourceFileTree` and `getSecondarySourceFileTree` now reports all of the source sets when
multiple languages are specified. This fix distinguishes between classic behaviour and
multi-language behaviour and will either return a single source set of a combination of source sets.

Credits to @ixchelruiz for helping to diagnose this problem at Hack.Commit.Push 2019.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.x Issues related to the 3.x
Projects
None yet
Milestone
3.0.0
Development

No branches or pull requests
1 participant
@ysb33r