Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cron? trigger flag to control cron scheduler creation #5

Closed
wants to merge 1 commit into from

Conversation

rellen
Copy link
Contributor

@rellen rellen commented Aug 10, 2023

Contributor checklist

  • Bug fixes include regression tests
  • Features include unit/acceptance tests

@rellen rellen force-pushed the feature/manual-trigger branch 2 times, most recently from 321042d to 3a3df2b Compare August 10, 2023 08:28
If `true` or not provided, the cron configuration for the trigger
will proceed as normal.

If `false`, no cron configuration will be added for the trigger.
The only way to run the trigger is manually, via `run_trigger`.
@rellen rellen changed the title feat: add manual? trigger flag to stop scheduler creation feat: add cron? trigger flag to stop scheduler creation Aug 10, 2023
@rellen rellen changed the title feat: add cron? trigger flag to stop scheduler creation feat: add cron? trigger flag to control scheduler creation Aug 10, 2023
@rellen rellen changed the title feat: add cron? trigger flag to control scheduler creation feat: add cron? trigger flag to control cron scheduler creation Aug 10, 2023
@rellen rellen mentioned this pull request Aug 10, 2023
@zachdaniel
Copy link
Contributor

Thanks for the PR I've done this a bit differently to accomplish a similar goal. In main now you can say scheduler_cron false to avoid building & setting up a cron scheduler.

@zachdaniel zachdaniel closed this Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants