feat: add validations on create evidence #1142
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those checks prevent the creation of empty evidences
luk3skyw4lker
requested review from
jkennedyvz,
jrozner and
JoelAtDeluxe
as code owners
|
Functionality looks good. @JoelAtDeluxe if you have some time would you mind taking a look at the react aspects and provide any comments on it? Otherwise I'm good to merge this. It doesn't implement any of the server side checks which might make sense to add at some point but this is good enough for now. |
|
@jrozner dang, I forgot about the server side checks, I can make them into a separate PR this week yet, but I really didn't remember them on this PR, sorry! |
|
No problem. It's fine doing them separately and like I said, this is good enough for now. I'm not concerned about security implications here, just people adding poor quality evidence. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding checks to prevent the creation of empty evidences