Added compatibility for flarum-tag-password extension #49
Conversation
…ussion stats from users without permission.
|
Fix design when view is very narrow, put spacing to ensure icon is not grouped closely to text.
|
…other themes. Recreate all styling to topNav, and keep sideNav for non-full screen mode. Fixed compact mobile view mode, where larger screen show sub tags on the right side.
|
Fixed: Missing 'Tags' in navigation, with 'Keep the tags page link in the nav sidebar?'
|
js/src/forum/index.js
Outdated
| @@ -9,10 +9,19 @@ import LastDiscussionWidget from './components/LastDiscussionWidget'; | |||
| import StatWidget from './components/StatWidget'; | |||
|
|
|||
| function pruneIndexNav(items, func) { | |||
| if (app.current.matches(CategoriesPage) && app.forum.attribute('categories.fullPageDesktop')) { | |||
| const isTagsVisible = !app.forum.attribute('categories.keep-tags-nav'); | |||
There was a problem hiding this comment.
Removing the tag navigation should not be checked if fullPageDesktop is true, hence why it's removed. This caused the Tag navigation to be shown for the user.
There was a problem hiding this comment.
Ah, I agree about the fullPageDesktop change. But you have isTagsVisible being set to the opposite of whether the user wants to keep tags. Shouldn't it be:
isTagsVisible = app.forum.attribute(... keep-tags-nav)?
There was a problem hiding this comment.
It seems I've used the wrong attributes, the latest commit is 'categories.keepTagsNav' and fixed the logic
| @@ -17,11 +17,18 @@ interface Attrs { | |||
| parent: any; | |||
| } | |||
|
|
|||
| interface TagLocked { | |||
There was a problem hiding this comment.
I'm not completely opposed to including features for the tag lock extension here, but would it be possible to add a comment here explaining which extension is adding this?
There was a problem hiding this comment.
Added comment for reference of Flarum Tag Passwords
js/src/forum/index.js
Outdated
| @@ -9,10 +9,19 @@ import LastDiscussionWidget from './components/LastDiscussionWidget'; | |||
| import StatWidget from './components/StatWidget'; | |||
|
|
|||
| function pruneIndexNav(items, func) { | |||
| if (app.current.matches(CategoriesPage) && app.forum.attribute('categories.fullPageDesktop')) { | |||
| const isTagsVisible = !app.forum.attribute('categories.keep-tags-nav'); | |||
There was a problem hiding this comment.
Ah, I agree about the fullPageDesktop change. But you have isTagsVisible being set to the opposite of whether the user wants to keep tags. Shouldn't it be:
isTagsVisible = app.forum.attribute(... keep-tags-nav)?
Add support for flarum-tag-passwords, where Admin can lock specific tag with Password and Group Permission, the template would need to prevent loading the stats and last discussion.
Here is an example of it turned on:
