Fix #404 panic when unnecessary sending normalMatrix uniform

asny · Feb 26, 2024 · 17b1f13 · 17b1f13
1 parent 8412146
commit 17b1f13
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/src/renderer/geometry/instanced_mesh.rs b/src/renderer/geometry/instanced_mesh.rs
@@ -230,7 +230,7 @@ impl Geometry for InstancedMesh {
         let instance_buffers = &self.instance_buffers.read().unwrap().0;
         if attributes.normal && instance_buffers.contains_key("instance_translation") {
             if let Some(inverse) = self.current_transformation.invert() {
-                program.use_uniform("normalMatrix", inverse.transpose());
+                program.use_uniform_if_required("normalMatrix", inverse.transpose());
             } else {
                 // determinant is float zero
                 return;

diff --git a/src/renderer/geometry/mesh.rs b/src/renderer/geometry/mesh.rs
@@ -110,7 +110,7 @@ impl Geometry for Mesh {
     ) {
         if attributes.normal {
             if let Some(inverse) = self.current_transformation.invert() {
-                program.use_uniform("normalMatrix", inverse.transpose());
+                program.use_uniform_if_required("normalMatrix", inverse.transpose());
             } else {
                 // determinant is float zero
                 return;

diff --git a/src/renderer/geometry/particles.rs b/src/renderer/geometry/particles.rs
@@ -257,7 +257,7 @@ impl Geometry for ParticleSystem {
     ) {
         if attributes.normal {
             if let Some(inverse) = self.transformation.invert() {
-                program.use_uniform("normalMatrix", inverse.transpose());
+                program.use_uniform_if_required("normalMatrix", inverse.transpose());
             } else {
                 // determinant is float zero
                 return;