Optimise full_screen_draw #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Get rid of the vertex buffer entirely, in favour of indexing vertex positions from an array within the vertex shader. Before this patch full_screen_draw is taking 18% of my frametime (mostly in creating and destroying the vertex buffer many times per from). After the patch it is reduced to 5%. Note that my app is very heavy on post-process effects - I expect the majority of apps will not see quite such a major difference.
asny
reviewed
May 29, 2024
|
I've tested on Chrome+WebGL and native MacOS. Have not had a chance to fire it up on other platforms Edit: Safari and Firefox for Mac both also work |
Cool. That's good enough for me 🙂 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Get rid of the vertex buffer entirely, in favour of indexing vertex positions from an array within the vertex shader.
Before this patch full_screen_draw is taking 18% of my frame time (mostly in creating and destroying the vertex buffer multiple times per frame):
After the patch it is reduced to 6%:
Note that my app is very heavy on post-process effects - I expect the majority of apps will not see quite such a major difference.