Skip to content
This repository has been archived by the owner on Dec 18, 2018. It is now read-only.

Not all request rejections are logged #1295

Closed
cesarblum opened this issue Jan 9, 2017 · 1 comment
Closed

Not all request rejections are logged #1295

cesarblum opened this issue Jan 9, 2017 · 1 comment
Assignees
@halter73 @cesarblum
Labels
3 - Done bug
Milestone
2.0.0-preview1

Comments

@cesarblum
Copy link
Contributor

BadHttpRequestExceptions caught in

KestrelHttpServer/src/Microsoft.AspNetCore.Server.Kestrel/Internal/Http/FrameOfT.cs

Line 196 in e55c624

catch (BadHttpRequestException ex)
are not being logged except when logged before being thrown (such as when calling Frame.RejectRequest), even though the comment in the catch block indicates that should be the case.

This is the case for requests containing invalid characters in headers (see aspnet/Mvc#5662), where the BadHttpRequestException is thrown from MemoryPoolIterator.GetAsciiString. This should be refactored BTW.
@cesarblum cesarblum self-assigned this Jan 9, 2017
@cesarblum cesarblum added the bug label Jan 9, 2017
@cesarblum
Copy link
Contributor Author

@muratg Please triage.

@cesarblum cesarblum mentioned this issue Jan 9, 2017
Closed
cesarblum pushed a commit that referenced this issue Jan 9, 2017
Log all rejected requests (#1295).
b51308f
@cesarblum cesarblum mentioned this issue Jan 9, 2017
Closed
cesarblum pushed a commit that referenced this issue Jan 9, 2017
Log all rejected requests (#1295).
7490c56
cesarblum pushed a commit that referenced this issue Jan 10, 2017
Log all rejected requests (#1295).
c695243
@cesarblum cesarblum mentioned this issue Jan 10, 2017
Closed
@muratg muratg modified the milestones: 1.2.0, 2.0.0 Jan 12, 2017
cesarblum pushed a commit that referenced this issue Jan 27, 2017
Log all rejected requests (#1295).
f794b59
This was referenced Mar 3, 2017
Merged
Merged
cesarblum pushed a commit that referenced this issue Mar 6, 2017
Log all rejected requests (#1295).
fda358d
cesarblum pushed a commit that referenced this issue Mar 6, 2017
Verify all request rejections are logged (#1295).
11c7eb5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@halter73 halter73

@cesarblum cesarblum

Labels
3 - Done bug
Projects
None yet
Milestone
2.0.0-preview1
Development

No branches or pull requests
3 participants
@halter73 @cesarblum @muratg