Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow © in copyright notices #10065

Merged
merged 1 commit into from
Feb 22, 2024
Merged

Allow © in copyright notices #10065

merged 1 commit into from
Feb 22, 2024

Conversation

charliermarsh
Copy link
Member

Closes #10061.

Copy link
Contributor

ruff-ecosystem results

Linter (stable)

✅ ecosystem check detected no linter changes.

Linter (preview)

✅ ecosystem check detected no linter changes.

@charliermarsh
Copy link
Member Author

@BurntSushi - Is there a cost to making the pattern non-ASCII here?

Copy link
Member

@BurntSushi BurntSushi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. It is rather unlikely that this introduces any additional cost. Since the regex starts with a literal (even though it's case insensitive), this is probably getting optimized via a nice prefix prefilter. The best kind. What comes after won't matter much, and the regex is already matching non-ASCII things. For example, \d matches 𝟜.

@charliermarsh charliermarsh merged commit 6fe15e7 into main Feb 22, 2024
17 checks passed
@charliermarsh charliermarsh deleted the charlie/cpy branch February 22, 2024 17:44
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CPY001: recognize copyright unicode symbol
2 participants