Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to plot virtual memory instead of real memory #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

na-ka-na
Copy link

No description provided.

@na-ka-na
Copy link
Author

Example plot

psrecord/main.py Outdated
ax2.plot(log['times'], log['mem_real'], '-', lw=1, color='b', label='real')
if plot_virtual_memory:
ax2.plot(log['times'], log['mem_virtual'], '-', lw=1, color='g', label='virt')
ax2.set_ylim(0., max(log['mem_virtual']) * 1.2)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix the indentation here to use four spaces instead of two?

@astrofrog
Copy link
Owner

Thanks for the pull request! Just a small comment above.

@na-ka-na
Copy link
Author

Fixed the indentation, thanks!

Copy link
Owner

@astrofrog astrofrog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@na-ka-na - thanks! To keep the plot de-cluttered, I think it might be nicer to get rid of the legends and instead for the y axis on the right we can write e.g.:

Real and Virtual memory

and color code the words according to the lines. What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants