Skip to content

Commit

Permalink
Remove unused compare method
Browse files Browse the repository at this point in the history
  • Loading branch information
aswinkarthik committed Apr 29, 2018
1 parent ff923a9 commit beadab5
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 48 deletions.
25 changes: 0 additions & 25 deletions pkg/digest/compare.go
Original file line number Diff line number Diff line change
Expand Up @@ -7,31 +7,6 @@ import (
"sync"
)

// Compare compares two Digest maps and returns the additions and modification
// keys as arrays.
func Compare(baseDigest, newDigest map[uint64]uint64) (additions []uint64, modifications []uint64) {
maxSize := len(newDigest)
additions = make([]uint64, maxSize)
modifications = make([]uint64, maxSize)

additionCounter := 0
modificationCounter := 0
for k, newVal := range newDigest {
if oldVal, present := baseDigest[k]; present {
if newVal != oldVal {
//Modifications
modifications[modificationCounter] = k
modificationCounter++
}
} else {
//Additions
additions[additionCounter] = k
additionCounter++
}
}
return additions[:additionCounter], modifications[:modificationCounter]
}

// Difference represents the additions and modifications
// between the two Configs
type Difference struct {
Expand Down
23 changes: 0 additions & 23 deletions pkg/digest/compare_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -8,29 +8,6 @@ import (
"github.com/stretchr/testify/assert"
)

func TestCompare(t *testing.T) {
baseDigest := map[uint64]uint64{
10000106069522789940: 11608188164212916000,
10000305084889337335: 11796412213504516000,
10024909476616779194: 14500526491611670000,
1004896778135186857: 15778011848259830000,
}

newDigest := map[uint64]uint64{
10000106069522789940: 11608188164212916000,
10000305084889337335: 11796412213504516001,
10049141081086325814: 12259600610026582000,
}

additions, modifications := digest.Compare(baseDigest, newDigest)

expectedAdditions := []uint64{10049141081086325814}
expectedModifications := []uint64{10000305084889337335}

assert.Equal(t, expectedAdditions, additions)
assert.Equal(t, expectedModifications, modifications)
}

func TestDiff(t *testing.T) {
base := `1,col-1,col-2,col-3,one-value
2,col-1,col-2,col-3,two-value
Expand Down

0 comments on commit beadab5

Please sign in to comment.