Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Detect also deleted rows when used with primary keys #28

Closed
robomotic opened this issue Sep 18, 2019 · 1 comment · Fixed by #29
Closed

Detect also deleted rows when used with primary keys #28

robomotic opened this issue Sep 18, 2019 · 1 comment · Fixed by #29

Comments

@robomotic
Copy link

Hello there,
I really love this tool, however when I do this:

csvdiff old.txt new.txt --primary-key 0,1 --format json > diff.json

Where for example old is:

key,data
a,1
b,2
c,3

And new is:

key,data
b,5
c,3
d,6

It will only detect that b has changed and d has been added but not that a has been deleted.

@aswinkarthik
Copy link
Owner

Thank you for the love 👍 Will add support for it without impacting performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants