Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed mosaic_support.sh #30

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Stefan9110
Copy link

Currently, both mosaic-support scripts open chrome by default and make it very hard for users that do not have a good understanding of filesystems to locate the keylogfile.txt file.

This pull request adds support for opening the default browser instead and also set the SSLKEYLOGFILE environment variable to point to the current directory.

The changes are only implemented for Linux (and partially for Mac), but I intend to modify both the Mac and Windows part of the script(s).

- Added support for all browsers for both Linux and Mac by opening the
  about:blank page.
- Automatically kill browser processes
- Ability to specify directly from the binary which website to open,
  with fallback to about:blank such that no connections are made
@fzovpec
Copy link
Collaborator

fzovpec commented Apr 9, 2024

Hi there! Thank you very much for your contribution. Your work most definitely deserves points (and personal thanks from CN team). It looks good and as by me your PR idea is great but we would like to test it's working before we merge which we will do in the next couple of days! Thank you for your understanding

@@ -0,0 +1,29 @@
#!/bin/bash

DEFAULT_WEBSITE="about:blank"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change the default website to example.org / example.com

Comment on lines +11 to +15
for BROWSER_BIN in "${BROWSER_BINS[@]}"; do
if command -v "$BROWSER_BIN" &>/dev/null; then
killall -9 "$BROWSER_BIN" &>/dev/null
fi
done
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we do the trick without killing all the open browsers?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this: can we actually just terminate the script asking the user to shut down their browser in case one is open instead of killing the process (output which browser they have to terminate as well)? We would avoid confusion among the people whose browser is all of the sudden turned off this way

@beelux beelux added the enhancement New feature or request label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants